git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGit PATCH 0/4] --diff-opts in config file

From
Karl Hasselström <kha@treskal.com>
Date
Jan 24, 2008, 08:06 UTC
Message-ID
<20080124075935.25525.24416.stgit@yoghurt>
In-Reply-To
<20080124074827.GA29572@nan92-1-81-57-214-146.fbx.proxad.net>

This is first two cleanup patches, followed by one patch that makes "stg show" handle diff options like the other commands, and last a patch that reads diff opts from the config file.

The first two patches are in kha/safe, but the latter two are in kha/experimental because -- as Yann pointed out -- it's good to make sure the design is OK before committing to it.

I've solved the problem of overriding the config on the command line by making --diff-opts='--foo --bar' _add_ options, and special-cased --diff-opts='' to clear all options, including those from the config file, since appending no options makes no sense.

We'll still have to consider if and how to support different options for different tools.

Oh, and Jon: is this what you wanted, by the way? :-)
---
Karl Hasselström (4):
      Read default diff options from the user's config
      Let "stg show" use the unified --diff-opts handling
      Refactor --diff-opts handling
      Remove unused default values
 examples/gitconfig       |    4 ++++
 stgit/commands/diff.py   |   14 ++++----------
 stgit/commands/edit.py   |   14 +++-----------
 stgit/commands/export.py |   12 +++---------
 stgit/commands/files.py  |   13 ++++---------
 stgit/commands/mail.py   |   12 +++---------
 stgit/commands/show.py   |   13 ++++---------
 stgit/commands/status.py |   17 +++++------------
 stgit/utils.py           |   13 +++++++++++++
 9 files changed, 43 insertions(+), 69 deletions(-)
-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Previous: Yann DirsonNext: Karl Hasselström
Message 4 of 10 in “stgit: config option for diff-opts”
  1. Jon SmirlJan 23, 2008
  2. Karl HasselströmJan 23, 2008
  3. Yann DirsonJan 24, 2008
  4. 0/4 --diff-opts in config fileKarl Hasselström, Jan 24, 2008
  5. 1/4 Remove unused default valuesKarl Hasselström, Jan 24, 2008
  6. 2/4 Refactor --diff-opts handlingKarl Hasselström, Jan 24, 2008
  7. 3/4 Let "stg show" use the unified --diff-opts handlingKarl Hasselström, Jan 24, 2008
  8. 4/4 Read default diff options from the user's configKarl Hasselström, Jan 24, 2008
  9. Karl HasselströmJan 24, 2008
  10. Jon SmirlJan 24, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.