Re: [PATCH 2/3] send-email: validate patches before sending anything

From: Jeff King <peff@peff.net>
Date: Jan 18, 2008, 19:12 UTC
Message-ID: <20080118191201.GB21044@coredump.intra.peff.net>
In-Reply-To: <76718490801180939v12112b5btd71dfb1fb5be5897@mail.gmail.com>

On Fri, Jan 18, 2008 at 12:39:45PM -0500, Jay Soffian wrote:

> > +                       return "patch contains line longer than 998 characters";
> How about offering the line number. e.g.:
> 
> return "patch line number $. is longer than 998 characters";

I think that is sensible (Junio, if you apply pre-1.5.4, can you mark it up? Otherwise I will put it in the post-1.5.4 resend).

> > +test_expect_success 'no patch was sent' '
> 
> Shouldn't that be "no patches were sent" to match the perl output?

It's purely an informational message for the test script output, so it doesn't matter.

-Peff