git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fast-import.c: don't try to commit marks file if write failed

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jan 18, 2008, 02:09 UTC
Message-ID
<20080118020911.GQ24004@spearce.org>
In-Reply-To
<7vmyr4jpww.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Brandon Casey <casey@nrlssc.navy.mil> writes:
> 
> > We also move the assignment of -1 to the lock file descriptor
> > up, so that rollback_lock_file() can be called safely after a
> > possible attempt to fclose(). This matches the contents of
> > the 'if' statement just above testing success of fdopen().
> >
> > Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> > ---
> 
> Shawn, could you lend an extra set of eyeballs on this one
> please?  It looks sane to me but obviously you are more familiar
> with the code.
I agree.
Acked-by: Shawn O. Pearce <spearce@spearce.org>
 
-- 
Shawn.
Previous: Junio C HamanoNext: Brandon Casey
Message 5 of 8 in “What's in git.git (stable frozen)”
  1. Junio C HamanoJan 17, 2008
  2. Johannes SixtJan 17, 2008
  3. fast-import.c: don't try to commit marks file if write failedBrandon Casey, Jan 17, 2008
  4. Junio C HamanoJan 17, 2008
  5. Shawn O. PearceJan 18, 2008
  6. Brandon CaseyJan 17, 2008
  7. Junio C HamanoJan 17, 2008
  8. Shawn O. PearceJan 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.