Re: [PATCH] Don't display crlf warning twice

From: Dmitry Potapov <dpotapov@gmail.com>
Date: Jan 14, 2008, 06:40 UTC
Message-ID: <20080114064036.GX2963@dpotapov.dyndns.org>
In-Reply-To: <B4297A2E-9F8F-4167-AB48-10AC1FB4E1D5@zib.de>

On Mon, Jan 14, 2008 at 07:17:26AM +0100, Steffen Prohaska wrote:

> 
> Your traces reveal that it is a racy condition that can trigger
> the double warnings.

It is not a racy condition. It is just another branch in the code, which happens when an existing file is modified. Your tests always added a new file, so they could not reproduce the problem.

> 
> Do you have a test case that reliably triggers the second call to
> convert_to_git()?

=========================================== git config core.autocrlf input

echo Hello > foo git add foo git commit -m 'add foo'

echo Hello >> foo unix2dos foo # This should trigger double crlf warning git add foo ===========================================

Dmitry