Re: [PATCH] gitweb: Change feeds from commit to commitdiff output.

From: Florian La Roche <laroche@redhat.com>
Date: Jan 11, 2008, 06:53 UTC
Message-ID: <20080111065348.GA3967@dudweiler.stuttgart.redhat.com>
In-Reply-To: <7vtzll5t4u.fsf@gitster.siamese.dyndns.org>

On Thu, Jan 10, 2008 at 12:21:21PM -0800, Junio C Hamano wrote:

Show 17 quoted lines

> Florian La Roche <laroche@redhat.com> writes:
> 
> > [PATCH] gitweb: Change feeds from commit to commitdiff output.
> >
> > Change feeds from displaying the commit to displaying the commitdiff
> > output. This way the patches are shown directly and code review is
> > done more easily via watching feeds.
> >
> > Signed-off-by: Florian La Roche <laroche@redhat.com>
> 
> I can see that easier access to commitdiff output is sometimes
> desirable.
> 
> If you are making this change unconditional, however, I think
> there needs a list discussion between you and the silent
> majority of people that have been perfectly happy with the
> current "log only" behaviour.

Hello Junio,

Right, this is a change in behaviour. Maybe a config option for this would be good, so that users can configure their wanted output style.

Show 7 quoted lines

> And to have that discussion, you first have to wake them up,
> which this patch would serve well as a wake-up call.  But if
> that was the purpose of the posting, please (1) mark the patch
> as such (commonly done by saying [RFC/PATCH] instead), and (2)
> keep me out of the "To:" list, if the patch is not for inclusion
> but for discussion ("cc:" is fine but it's redundant as long as
> you are sending to the list).

Ok.

Show 5 quoted lines

> After such a discussion, we may end up finding out that
> everybody have been silently unhappy and wanted to have
> commitdiff there, and agree on doing this unconditionally.
> 
> But we do not know that yet.

>From asking people, most don't use feeds to follow development

checkins, but prefer to keep with mailinglists and looking only at the repos for their own interesting parts.

Hope more people will speak up here on the git@ list.

Thanks a lot,

Florian La Roche