wherefore art thou, git-applymbox? - Adding non-self signoffs
- From
- Joel Becker <joel.becker@oracle.com>
- Date
- Jan 4, 2008, 01:50 UTC
- Message-ID
- <20080104015028.GC3989@mail.oracle.com>
Junio, et al, When git-applymbox disappeared, I didn't pay much attention. I just learned git-am and went along. Little did I know, there was a trap laid. The ocfs2-tools.git repository is maintained by the entire ocfs2 team. It's a "shared" style repo. A proposed change is posted to ocfs2-tools-devel, and when a teammate approves, they respond with a signoff. The author then adds the signoff to the patch and pushes to the shared repo. We used to do this very easily with git-applymbox: (from http://oss.oracle.com/osswiki/GitRepositories/ForMaintainers)
$ echo "Julie Hacker <julieh@my.site.com>" > /tmp/signoff $ git branch to-push master $ git checkout to-push $ git format-patch -C -k --stdout master..workingbranch > /tmp/changes-to-push $ git applymbox -k /tmp/changes-to-push /tmp/signoff $ git push ssh://my.server.com/path/project.git to-push:master
The <signoff> file argument to applymbox allowed us to add the approvers signoff to an entire series in one go. git-am does not have this feature. As far as I can tell, I have to edit each patch by hand to add the new signoff. Is there a better way?
Joel
-- Life's Little Instruction Book #356 "Be there when people need you." Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127