On ven, déc 21, 2007 at 12:32:28 +0000, Junio C Hamano wrote:
Show 12 quoted lines
> I've tagged -rc1 last night. The changes are mostly fixes. There are
> some remaining issues I'd like to see fixed/decided before 1.5.4.
>
> One important issue is to identify and fix regressions since 1.5.3
> series. No "rewrite scripted git-foo completely in C" can be regression
> free, and we had quite a few internal changes during 1.5.4 cycle (not
> just rewrite to C, but C level uses new and improved API such as strbuf
> and parse-options). Currently I am aware of these regressions:
>
> * handling of options, "--abbrev 10 HEAD", "--abbrev=10 HEAD" and
> "--abbrev HEAD". The last one does not work for commands that use
> parse-options. Pierre is on top of this, I hope.
About that, I know we talked about the -default thing and so on, I'm
not sure we should hurry that for 1.5.4 for the following reasons:
* I grepped through the source and the _sole_ instance of
parse-options enabled option arguments are --abbrev ones for now
(even in the shell scripts migrated to git rev-parse --parseopt). * Not adding *-default and lax parsing for optional arguments is _not_
a regression for the migrated commands. * I don't want to urge that because well, I still have the hope we
could come up with something even better. So I'd argue in favor of that:
+ push the patch that forces the stuck forms (that I already posted)
for 1.5.4.
+ prepare a series in pu with *-default post 1.5.4 to evaluate this
and see what people think. Most of the function with optional arguments are the git diff ones,
and we'll see about them post 1.5.4 anyways.
Pierre Habouzit <madcoder@debian.org>