Re: [PATCH] git-commit: add --verbatim to allow unstripped commit messages

From: Alex Riesen <raa.lkml@gmail.com>
Date: Dec 20, 2007, 23:33 UTC
Message-ID: <20071220233324.GB3052@steel.home>
In-Reply-To: <alpine.LFD.0.9999.0712201324270.21557@woody.linux-foundation.org>

Linus Torvalds, Thu, Dec 20, 2007 22:40:13 +0100:

Show 12 quoted lines

> On Thu, 20 Dec 2007, Alex Riesen wrote:
> > 
> > I just happen to have a corporate template (for perforce messages, I
> > reuse it my git mirror repo) which contains "#" and at least one time
> > lost my bash comments in a commit.
> 
> I think that this is a real bug, but I don't think this is something that 
> we should add a flag for.
> 
> Basically, I don't think we should really strip lines starting with '#' 
> unless *we* added them. In particular, I don't think we should strip them 
> at all unless we're running the editor.

Right

> That may be enough for your case, although it still does leave the "use 
> editor on a template thing", so if that is your usage scenario, I guess we 
> still do need a flag for it.

Yes, I afraid I need both. I use "git commit -t" almost (submission in perforce takes careful planning) every day. I also would like to keep the empty leading and trailing lines (perforce default GUI P4Win does not show them, but our scripts which check the descriptions will test the description text according to template which does have trailing empty lines).

Show 6 quoted lines

> But even if we *do* add a flag (like "--verbatim") you should at the 
> *least* also then remove the
> 
> 	"# (Comment lines starting with '#' will not be included)\n"
> 
> printout! Which you didn't.

I did think about it. It wont be read, I believe (at least I ignore the status listing git-commit generates today). But then, it can be removed for verbatim message as no one (I think) will probably care. Including the "Please..." so it does not look stupid in the commit message later. Will do.

> > It also implies --allow-empty.
> 
> I disagree with this one too.
>

I agree. Will remove (I am not even sure myself, why I did that. It is not even tested)