Re: [PATCH] Don't cache DESTDIR in perl/perl.mak.

From: Gerrit Pape <pape@smarden.org>
Date: Dec 18, 2007, 14:25 UTC
Message-ID: <20071218142537.23571.qmail@5b1a609bf11950.315fe32.mid.smarden.org>
In-Reply-To: <20071212200211.GB1060@artemis.madism.org>

On Wed, Dec 12, 2007 at 09:02:11PM +0100, Pierre Habouzit wrote:

Show 5 quoted lines

> On Wed, Dec 12, 2007 at 06:01:48PM +0000, Eric Wong wrote:
> > Junio C Hamano <gitster@pobox.com> wrote:
> > > Hmph.  That's reverting this:
> > > 
> > > commit 4c5cf8c44ce06a79da5bafd4a92e6d6f598cea2e

Show 20 quoted lines

> > > Eric, care to comment?
> > 
> > I used to make a statically linked binary package for working on an
> > ancient box that didn't have a lot of libraries I wanted, and I probably
> > just called `make install' into DESTDIR as a single step without calling
> > `make' alone without DESTDIR argument, or I had DESTDIR set in
> > config.mak
> 
>   Actually this fact generated a bug in debian packaging because git is
> built then installed twice in different DESTDIRS, then parts of the
> install is pruned (the two installs are arch-dependant and
> arch-independant files install so it's a very good reason in term of
> packaging).
> 
>   The fact that perl.mak caches the DESTDIR make it install things in
> the wrong place because it doesn't honour make DESTDIR=foo install and
> always use the cached value instead, which is wrong.
> 
>   I think Gerrit won't care if it's cached or not, he just cares that it
> still honours environment if present.

Yes, precisely.  Thanks, Gerrit.