git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-svn rebase issues (the commiter gets changed)

From
EWEric Wong <normalperson@yhbt.net>
Date
Dec 16, 2007, 03:39 UTC
Message-ID
<20071216033947.GB17666@muzzle>
In-Reply-To
<20071216032523.GA17666@muzzle>
Eric Wong <normalperson@yhbt.net> wrote:
Show 18 quoted lines
> From 84e99bffc72c10ec7db6d5ae7af6a795b75ef724 Mon Sep 17 00:00:00 2001
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>  git-svn.perl |   50 +++++++++++++++++++++++++++++++++++++++-----------
>  1 files changed, 39 insertions(+), 11 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index d411a34..7cd62fc 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2089,5 +2116,6 @@ sub do_git_commit {
>  	defined(my $pid = open3(my $msg_fh, my $out_fh, '>&STDERR', @exec))
>  	                                                           or croak $!;
>  	print $msg_fh $log_entry->{log} or croak $!;
> +	restore_commit_header_env($old_env);
>  	unless ($self->no_metadata) {
>  		print $msg_fh "\ngit-svn-id: $log_entry->{metadata}\n"
> \ No newline at end of file
Hi Junio,
This "\ No newline at end of file" from git-format-patch seems wrong.
Bisecting reveals that it started happening at:
  913b45f51b151d8e29f86df67d3e10853d831470
  xdi_diff: trim common trailing lines
-- 
Eric Wong
Previous: Eric WongNext: Junio C Hamano
Message 5 of 7 in “git-svn rebase issues (the commiter gets changed)”
  1. Kelvie WongNov 22, 2007
  2. Eric WongNov 29, 2007
  3. Kelvie WongNov 29, 2007
  4. Eric WongDec 16, 2007
  5. Eric WongDec 16, 2007
  6. Junio C HamanoDec 16, 2007
  7. Kelvie WongDec 18, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.