Re: git-browse-help?
- From
Jeff King <peff@peff.net>
- Date
- Dec 15, 2007, 11:11 UTC
- Message-ID
- <20071215111154.GB3447@coredump.intra.peff.net>
- In-Reply-To
- <20071215110153.GA3447@coredump.intra.peff.net>
On Sat, Dec 15, 2007 at 06:01:53AM -0500, Jeff King wrote:
> problem. Shawn, perhaps it should simply ignore *--* as plumbing?
And here is a patch to do that.
-- >8 -- teach bash completion to treat commands with "--" as plumbing
There is a convention that commands containing a double-dash are implementation details and not to be used by mortals. We should automatically remove them from the completion suggestions as plumbing.
Signed-off-by: Jeff King <peff@peff.net> --- BTW, Junio, I remember discussion a long time ago about doing:
cover letter -- >8 -- commit --- diff
versus
commit --- cover letter diff
and I recall that you did not have a strong preference. I have started using the former, as I find it a bit more convenient to write (and I think it is more readable when you are following up a discussion rather than writing a real cover letter or commenting on the patch). However, I wanted to confirm that you don't find it significantly more annoying.
contrib/completion/git-completion.bash | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 58e0e53..2fd32db 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -291,7 +291,7 @@ __git_commands () for i in $(git help -a|egrep '^ ') do case $i in - add--interactive) : plumbing;; + *--*) : plumbing pattern;; applymbox) : ask gittus;; applypatch) : ask gittus;; archimport) : import;; @@ -308,7 +308,6 @@ __git_commands () diff-tree) : plumbing;; fast-import) : import;; fsck-objects) : plumbing;; - fetch--tool) : plumbing;; fetch-pack) : plumbing;; fmt-merge-msg) : plumbing;; for-each-ref) : plumbing;;
-- 1.5.4.rc0.1124.g1b66f-dirty