Re: git-cvsexportcommit fails for huge commits

From: Jeff King <peff@peff.net>
Date: Dec 14, 2007, 04:45 UTC
Message-ID: <20071214044554.GB10169@sigill.intra.peff.net>
In-Reply-To: <7vzlwevu2k.fsf@gitster.siamese.dyndns.org>

On Thu, Dec 13, 2007 at 07:22:43PM -0800, Junio C Hamano wrote:

Show 5 quoted lines

> Sorry, you are right.
> 
> Perhaps pick a reasonably small but not insanely small value, like 16kB,
> forget about the atomicity issues for now, as an interim improvement
> patch?

I'm fine with that. We can probably go a bit higher than that. From my limited testing[1]:

  Linux 2.6.18: ~128K
  Linux 2.6.23: huge? I tried ~350K and it worked fine
  Solaris: huge? I tried ~350K and it worked fine
  Freebsd 6.1: ~256K

So it seems that we could probably go with something more like 64K, and then only truly pathological cases should trigger the behavior.

-Peff

[1] All numbers are approximate and determined experimentally with
something like:
  for i in `seq 1 $n`; do
    touch $long_filename-$i
  done
  ls * | wc