Re: git describe candidate filtering

From: Shawn O. Pearce <spearce@spearce.org>
Date: Dec 13, 2007, 05:57 UTC
Message-ID: <20071213055746.GV14735@spearce.org>
In-Reply-To: <4760C250.5080103@byu.net>

Eric Blake <ebb9@byu.net> wrote:

Show 6 quoted lines

> Would it be possible to add an option to git-describe that limits the
> candidate tags to those matching a glob pattern or regular expression?
> I've got a repository imported from CVS which has a number of less
> interesting tags for events such as branch creation, but I'm only
> interested in describing the current commit relative to tags matching
> v[0-9]\.[0-9]*, rather than the closest tag of any spelling.

Sure, it shouldn't be too difficult, just need to alter the get_name() function to add the item with add_to_known_names() only if it matches the pattern. Take a look at builtin-describe.c around line 74...

We only match things that were "added". So if you don't add a tag via add_to_known_names() then git-describe won't return it.

However that's only true for the standard case; for --contains its a different story as we are actually passing everything to name-rev.

-- 
Shawn.