Re: [PATCH] Fix clone not to ignore depth when performing a local clone

From: Charles Bailey <charles@hashpling.org>
Date: Dec 11, 2007, 18:26 UTC
Message-ID: <20071211182603.GA4063@hashpling.org>
In-Reply-To: <Pine.LNX.4.64.0712111154070.27959@racer.site>

On Tue, Dec 11, 2007 at 11:54:54AM +0000, Johannes Schindelin wrote:

Show 23 quoted lines

> Hi,
> 
> On Tue, 11 Dec 2007, Charles Bailey wrote:
> 
> > @@ -205,7 +205,10 @@ fi
> >  # it is local
> >  if base=$(get_repo_base "$repo"); then
> >  	repo="$base"
> > -	local=yes
> > +	if test -z "$depth"
> > +	then
> > +		local=yes
> > +	fi
> >  fi
> 
> Or shorter:
> 
> -	local=yes
> +	test -z "$depth" && local=yes
> 
> Ciao,
> Dscho
>

Yes, I have no particular preference. I was just following the 'convention' of the -z "$origin" test a few lines above although I could see uses of both alternatives as well as instances of [...] instead of test ... .

Charles.