git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Better errors when trying to merge a submodule

From
Finn Arne Gangstad <finnag@pvv.org>
Date
Dec 11, 2007, 18:11 UTC
Message-ID
<20071211181110.GA16491@pvv.org>
In-Reply-To
<7vsl2al5ia.fsf@gitster.siamese.dyndns.org>
On Mon, Dec 10, 2007 at 11:22:05AM -0800, Junio C Hamano wrote:
Show 18 quoted lines
> Finn Arne Gangstad <finnag@pvv.org> writes:
> 
> > Instead of dying with weird errors when trying to merge submodules from a
> > supermodule, emit errors that show what the problem is.
> 
> Thanks.
> 
> Your change to merge-one-file.sh is Ok, although I'd reword the message
> a bit, and fold it as a new case arm to the existing case statement
> immediately above.
> [...]
> merge-recursive did not support merging trees that have conflicting
> changes in submodules they contain, and died.  Support it exactly the
> same way as how it handles conflicting symbolic link changes --- mark it
> as a conflict, take the tentative result from the current side, and
> letting the caller resolve the conflict, without dying in merge_file()
> function.
> [...]

Your patch is obviously much nicer than the one I sent in, so please put it in if/when convenient!

On another note, has there been any though to get merge to support sub-module merging properly? It seems like it should be possible (and it would make submodules a lot more useful)

- Finn Arne
Previous: Junio C Hamano
Message 3 of 3 in “Better errors when trying to merge a submodule”
  1. Better errors when trying to merge a submoduleFinn Arne Gangstad, Dec 10, 2007
  2. Junio C HamanoDec 10, 2007
  3. Finn Arne GangstadDec 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.