Re: [PATCH] t7004: test that "git-tag -u" implies "-s"

From: Jeff King <peff@peff.net>
Date: Dec 11, 2007, 05:22 UTC
Message-ID: <20071211052257.GA350@coredump.intra.peff.net>
In-Reply-To: <7v63z5j16g.fsf@gitster.siamese.dyndns.org>

On Mon, Dec 10, 2007 at 08:38:31PM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> +get_tag_header implied-sign $commit commit $time >expect
> +echo 'Another signed tag' >>expect
> +echo '-----BEGIN PGP SIGNATURE-----' >>expect
> +test_expect_success '-u implies signed tag' '
> +	git-tag -u CDDE430D -m "Another signed tag" implied-sign &&
> +	get_tag_msg implied-sign >actual &&
> +	git diff expect actual
> +'

One thing that my original did test but this version doesn't: not only does -u imply -s, but -u implies -s which implies -a. IOW, using "-u" will put you in an editor (and a poorly done fix might have gotten this wrong, but apparently Linus is a super-genius).

Your other two tests look good.

-Peff