Re: [PATCH 2/3] git config --get-colorbool

From: Jeff King <peff@peff.net>
Date: Dec 6, 2007, 05:35 UTC
Message-ID: <20071206053514.GA23201@coredump.intra.peff.net>
In-Reply-To: <20071206053059.GF5499@coredump.intra.peff.net>

On Thu, Dec 06, 2007 at 12:30:59AM -0500, Jeff King wrote:

> Also, your patch doesn't seem to implement the color.pager/pager.color
> behavior, either (which is probably not important for git-add -i, but is
> used by git-svn).

Oops, maybe I should actually read your patch more carefully before criticizing. I see that you do handle pager_use_color in git_config_colorbool, but I think that for --get-colorbool usage, pager_in_use is going to be useless (wow, three forms of "use" in one clause).

-Peff