Re: [PATCH] Reorder msgfmt command-line arguments.

From: brian m. carlson <sandals@crustytoothpaste.ath.cx>
Date: Dec 3, 2007, 17:04 UTC
Message-ID: <20071203170402.GA13712@crustytoothpaste.ath.cx>
In-Reply-To: <Pine.LNX.4.64.0712031034200.27959@racer.site>

On Mon, Dec 03, 2007 at 10:35:33AM +0000, Johannes Schindelin wrote:

Show 8 quoted lines

>On Mon, 3 Dec 2007, brian m. carlson wrote:
>
>> Any program using getopt or getopt_long will stop processing options 
>> once a non-option argument has been encountered, if POSIXLY_CORRECT is 
>> set.
>
>So have you tested that msgfmt indeed does not work with the present 
>command line?

Yes. I run with POSIXLY_CORRECT set to 1, and it does indeed break. I wouldn't have fixed it if it had worked.

There are parts of the git testsuite that hang in this case, too, but I have yet to examine them. Rest assured that there are indeed patches coming, assuming the problems are fixable.

>Besides, you probably want to send this as a git-gui patch: based on 
>git-gui.git, not git.git, and Cc'ed to Shawn Pearce.

Thanks.  Will do.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 713 440 7475 | http://crustytoothpaste.ath.cx/~bmc | My opinion only
a typesetting engine: http://crustytoothpaste.ath.cx/~bmc/code/thwack
OpenPGP: RSA v4 4096b 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187