Re: Fix a pathological case in git detecting proper renames
- From
Jeff King <peff@peff.net>
- Date
- Nov 29, 2007, 23:52 UTC
- Message-ID
- <20071129235253.GA10261@coredump.intra.peff.net>
- In-Reply-To
- <alpine.LFD.0.9999.0711291442300.8458@woody.linux-foundation.org>
On Thu, Nov 29, 2007 at 03:03:06PM -0800, Linus Torvalds wrote:
> This would probably become easier to do with the linear-time hash-based > similarity engine (the stuff Jeff King was working on), but the way the > code is currently structured - with no incremental rename detection at > all, and with all the scoring in one global table - it's pretty painful.
I think it will get worse, because you are simultaneously calculating all of the similarity scores bit by bit rather than doing a loop. Though perhaps you mean at the end you will end up with a list of src/dst pairs sorted by score, and you can loop over that.
-Peff