Re: [PATCH] Make Git accept absolute path names for files within the work tree

From

Robin Rosenberg <robin.rosenberg@dewire.com>

Date

Nov 27, 2007, 23:20 UTC

Message-ID

<200711280020.57042.robin.rosenberg@dewire.com>

In-Reply-To

<7vmyt0edso.fsf@gitster.siamese.dyndns.org>

tisdag 27 november 2007 skrev Junio C Hamano:

> Robin Rosenberg <robin.rosenberg@dewire.com> writes:

[...]

> >  	const char *orig = path;
> 
> Decl after statement.

Stupid C..

> 
> I do not think there is fundamental reason to object to this change, as
> long as the prefixing is done to the path that is trying to name a path
> in the working tree.
> 
> Also some codepath that does not require any work tree may want to call
> prefix_path().  I do not know what would happen in such a case.

ok, I'll add a test for whether we have a work tree.

> Although I didn't look at all the callers, I think the caller from
> config.c is not talking about a path in the work tree, and not all users
> of config.c need to have work-tree.

-- robin