git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Tweak git-quiltimport to allow more flexible series format

From
ADAlexey Dobriyan <adobriyan@sw.ru>
Date
Nov 27, 2007, 16:52 UTC
Message-ID
<20071127165220.GA6220@localhost.sw.ru>
In-Reply-To
<7vsl2x26di.fsf@gitster.siamese.dyndns.org>
On Thu, Nov 22, 2007 at 03:43:53PM -0800, Junio C Hamano wrote:
Show 26 quoted lines
> Alexey Dobriyan <adobriyan@sw.ru> writes:
> 
> > Make quiltimport also understand comments following patch name.
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> > ---
> >
> >  git-quiltimport.sh |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/git-quiltimport.sh
> > +++ b/git-quiltimport.sh
> > @@ -63,7 +63,7 @@ tmp_info="$tmp_dir/info"
> >  commit=$(git rev-parse HEAD)
> >  
> >  mkdir $tmp_dir || exit 2
> > -for patch_name in $(grep -v '^#' < "$QUILT_PATCHES/series" ); do
> > +for patch_name in $(sed -e 's/#.*//' < "$QUILT_PATCHES/series" ); do
> >  	if ! [ -f "$QUILT_PATCHES/$patch_name" ] ; then
> >  		echo "$patch_name doesn't exist. Skipping."
> >  		continue
> 
> Is this consistent with the way quilt groks the series file?
> 
> IOW, does quilt forbid patchfile whose name contains a hash, and
> anything after a hash on the line is taken as comment?
It looks like hash inside a patch name is legal.
 
> Can a line in a quilt series file name more than one patchfile?

No. Which means we can probably do sed -e 's/^#//' -e 's/[ \t]#.*//' ... let me experiment bit more.

> If so, are they whitespace separated?
Previous: Junio C Hamano
Message 3 of 3 in “Tweak git-quiltimport to allow more flexible series format”
  1. Tweak git-quiltimport to allow more flexible series formatAlexey Dobriyan, Nov 22, 2007
  2. Junio C HamanoNov 22, 2007
  3. Alexey DobriyanNov 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.