git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Revert "t5516: test update of local refs on push"

From
Jeff King <peff@peff.net>
Date
Nov 21, 2007, 07:19 UTC
Message-ID
<20071121071934.GA10112@sigill.intra.peff.net>
This reverts commit 09fba7a59d38d1cafaf33eadaf1d409c4113b30c.

These tests are superseded by the ones in t5404 (added in 6fa92bf3 and 8736a848), which are more extensive and better organized.

Signed-off-by: Jeff King <peff@peff.net>
---
When Alex introduced t5404, I had the feeling I had written similar
tests before, but I failed to find them. I think starting t5404 was a
much more sensible organization, especially since these two tests don't
follow the style of the rest of t5516 very well.
 t/t5516-fetch-push.sh |   28 ----------------------------
 1 files changed, 0 insertions(+), 28 deletions(-)
diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
index 86f9b53..4fbd5b1 100755
--- a/t/t5516-fetch-push.sh
+++ b/t/t5516-fetch-push.sh
@@ -254,32 +254,4 @@ test_expect_success 'push with dry-run' '
 	check_push_result $old_commit heads/master
 '
 
-test_expect_success 'push updates local refs' '
-
-	rm -rf parent child &&
-	mkdir parent && cd parent && git init &&
-		echo one >foo && git add foo && git commit -m one &&
-	cd .. &&
-	git clone parent child && cd child &&
-		echo two >foo && git commit -a -m two &&
-		git push &&
-	test $(git rev-parse master) = $(git rev-parse remotes/origin/master)
-
-'
-
-test_expect_success 'push does not update local refs on failure' '
-
-	rm -rf parent child &&
-	mkdir parent && cd parent && git init &&
-		echo one >foo && git add foo && git commit -m one &&
-		echo exit 1 >.git/hooks/pre-receive &&
-		chmod +x .git/hooks/pre-receive &&
-	cd .. &&
-	git clone parent child && cd child &&
-		echo two >foo && git commit -a -m two || exit 1
-		git push && exit 1
-	test $(git rev-parse master) != $(git rev-parse remotes/origin/master)
-
-'
-
 test_done
-- 
1.5.3.6.1786.g2e199
Message 1 of 1 in “Revert "t5516: test update of local refs on push"”
  1. Revert "t5516: test update of local refs on push"Jeff King, Nov 21, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.