Re: t9106 failure, bisect weirdness

From: Christian Couder <chriscool@tuxfamily.org>
Date: Nov 21, 2007, 04:08 UTC
Message-ID: <200711210508.27455.chriscool@tuxfamily.org>
In-Reply-To: <20071120061314.GA21819@net-ronin.org>

Le mardi 20 novembre 2007, carbonated beverage a écrit :

Show 15 quoted lines

> > Could you try running the test twice when you bisect ?
> > This way bisecting should give you the real first bad commit.
>
> I re-ran it several times, and also manually -- there were times it'd
> succeed 6 times in a row before failing.  Weird.
>
> Finally, the bisect came down to:
>
>   ramune/lycaeum:git: git bisect good
>   c74d9acf20ba0c69bbd67c5b0bb3bd3c2349cebe is first bad commit
>   commit c74d9acf20ba0c69bbd67c5b0bb3bd3c2349cebe
>   Author: Eric Wong <normalperson@yhbt.net>
>   Date:   Mon Nov 5 03:21:47 2007 -0800
>
>       git-svn: fix dcommit clobbering when committing a series of diffs

Thanks for having done that. Unfortunately I don't know this part of the code, so I cc'ed Eric.

Show 11 quoted lines

> Modifying the failing t9106-git-svn-dcommit-clobber-series.sh test to
> add touch statements as so:
>
>   test x\"\`sed -n -e 4p < file\`\" = x4444 && touch '/tmp/eleven' &&
>   test x\"\`sed -n -e 7p < file\`\" = x7777 && touch '/tmp/twelve' &&
>   test x\"\`sed -n -e 58p < file\`\" = x5588 && touch '/tmp/thirteen' &&
>   test x\"\`sed -n -e 61p < file\`\" = x6611
>
> Line 52 was the culprit:
>
>   test x\"\`sed -n -e 58p < file\`\" = x5588 &&

Ok thanks for doing that too. Could you also look at the "file" when the test succeed and when it does not and send us both versions and a diff between them (if it's not too big).

Thanks in advance, Christian.