Re: [PATCH 1/2] send-pack: cluster ref status reporting

From: Alex Riesen <raa.lkml@gmail.com>
Date: Nov 20, 2007, 18:22 UTC
Message-ID: <20071120182233.GA3461@steel.home>
In-Reply-To: <20071120111801.GA7814@sigill.intra.peff.net>

Jeff King, Tue, Nov 20, 2007 12:18:01 +0100:

Show 5 quoted lines

> Instead of intermingling success and failure, we now print:
> 
>   1. all uptodate refs (if args.verbose is enabled)
>   2. successfully pushed refs
>   3. failed refs

I vote for this. The non-ff refs clustered together was the real reason behind my beautification patch.

Show 6 quoted lines

> I am somewhat ambivalent on this patch. In most cases, it won't make a
> difference, since the output is small enough. For large pushes, it might
> be better to have errors at the end. OTOH, you do still get "error:
> failed to push to ..." at the end, and you can scroll up and see the
> errors if you like. And it's not like preserving the original ref output
> order was all that interesting.

It is just simplier to distinguish visually: non-ff's are formatted significantly different. You don't even have to read what is written to immediately notice if there are problems.