[PATCH] send-email: add transfer encoding header with content-type
- From
Jeff King <peff@peff.net>
- Date
- Nov 20, 2007, 12:54 UTC
- Message-ID
- <20071120125404.GB7998@sigill.intra.peff.net>
- In-Reply-To
- <20071119104950.GB8645@informatik.uni-freiburg.de>
We add the content-type header only when we have non-7bit characters from the 'From' header, so we really need to specify the encoding (in other cases, where the commit text needed a content-type, git-format-patch will already have added the encoding header).
Signed-off-by: Jeff King <peff@peff.net> --- On Mon, Nov 19, 2007 at 11:49:50AM +0100, Uwe Kleine-König wrote:
Show 6 quoted lines
> but no Content-Transfer-Encoding:. This yield a 7bit mail with 8bit > characters. > > I think we should add > > Content-Transfer-Encoding: 8bit
Even though Brian's mail turned out to be hand-generated, this problem does exist in git-send-email. I don't know why I didn't add the encoding header in the first place, since it is clearly required.
Junio, I think this is maint-worthy.
git-send-email.perl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index fd0a4ad..d7b8391 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -781,7 +781,8 @@ foreach my $t (@files) { else { push @xh, 'MIME-Version: 1.0', - "Content-Type: text/plain; charset=$author_encoding"; + "Content-Type: text/plain; charset=$author_encoding", + 'Content-Transfer-Encoding: 8bit'; } } }
-- 1.5.3.6.1784.gd1b1d-dirty