Re: [PATCH] send-pack: improve error reporting for total remote unpack

From: Jeff King <peff@peff.net>
Date: Nov 18, 2007, 07:09 UTC
Message-ID: <20071118070910.GA23410@sigill.intra.peff.net>
In-Reply-To: <20071118055804.GA19313@sigill.intra.peff.net>

On Sun, Nov 18, 2007 at 12:58:06AM -0500, Jeff King wrote:

Show 7 quoted lines

> One other thing I noticed while doing this patch is that our remote ref
> status reporting isn't foolproof.  We set every ref we send to 'OK' with
> the nice effect that if status reporting isn't enabled, we just assume
> that it worked. However, if the status coming back is truncated (i.e.,
> some refs are missing in receive_status), we will just fail to notice and
> assume all is well. So to be perfect, we would need a
> REF_STATUS_EXPECTING_REPORT.

This turned out to be pretty easy, given the other recent changes, and I think it actually makes the code a bit clearer. Please scrap the patch to which I am replying, and I will post a replacement series in a second.

-Peff