Re: [PATCH 3/3 v2] git-svn log: handle unreachable revisions like "svn log"

From: Eric Wong <normalperson@yhbt.net>
Date: Nov 17, 2007, 21:47 UTC
Message-ID: <20071117214738.GB22835@soma>
In-Reply-To: <1194850612-6907-1-git-send-email-ddkilzer@kilzer.net>

David D Kilzer <ddkilzer@kilzer.net> wrote:

Show 21 quoted lines

> When unreachable revisions are given to "svn log", it displays all commit
> logs in the given range that exist in the current tree.  (If no commit
> logs are found in the current tree, it simply prints a single commit log
> separator.)  This patch makes "git-svn log" behave the same way.
> 
> Ten tests added to t/t9116-git-svn-log.sh.
> 
> Signed-off-by: David D Kilzer <ddkilzer@kilzer.net>
> ---
> 
> No changes were needed to parts 1 and 2 of this series, so I am not
> reposting them.
> 
> Updated this patch based on feedback from Benoit Sigoure and Eric Wong:
> 
> - Commented find_rev_before() and find_rev_after().
> - Changed commit_log_separator() into a constant.
> - Made return statement safer by adding another check in git_svn_log_cmd().
> - Changed echo statement to printf in t/t9116-git-svn-log.sh.
> 
> All tests pass on maint branch.

Thanks,

Acked and pushed out to http://git.bogomips.org/git-svn.git

David D Kilzer (3):
      git-svn log: fix ascending revision ranges
      git-svn log: include commit log for the smallest revision in a range
      git-svn log: handle unreachable revisions like "svn log"

David Reiss (1):
      git-svn: Fix a typo and add a comma in an error message in git-svn

Eric Wong (1):
      git-svn: add tests for command-line usage of init and clone commands

Konstantin V. Arkhipov (1):
      git-svn's dcommit must use subversion's config

-- 
Eric Wong