git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] Add to gitk an --argscmd flag to get the list of refs to draw at refresh time.

From
Yann Dirson <ydirson@altern.org>
Date
Nov 17, 2007, 19:56 UTC
Message-ID
<20071117195659.GO8855@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To
<18238.54272.198637.788805@cargo.ozlabs.ibm.com>
Hi Paul,
I hope I did not introduce other problems while trying to adress those.
On Sat, Nov 17, 2007 at 10:44:00PM +1100, Paul Mackerras wrote:
> What this will do is interpret the output of the program according to
> Tcl list syntax.

I'm not sure of why this interpretation is done, so it may well be that the updated patch would behave the same.

> use error_popup rather than just writing to stderr.

While testing that, I realized that the current behaviour is not very friendly. While it is OK to exit on error here, when the command has been entered on command-line, it would be rude to exit when the user makes a typo when editing the view. It would be more friendly to get back to the "edit view" dialog instead; I'm not sure we can already tell in which of the 2 situations we are - would you conisider adding a global flag for tracking this to be an adequate solution ?

> > +set revtreeargscmd None
> 
> Why the string "None" rather than the empty string?  Is this a
> python-ism that has crept in?

Note completely - since there were already occurences of None in gitk, I assumed it was a special value in Tcl. Should I have searched in more details, I would have noticed the string comparisons.

Best regards,
-- 
Yann
Previous: Paul Mackerras
Message 3 of 3 in “Add to gitk an --argscmd flag to get the list of refs to draw at refresh time.”
  1. Add to gitk an --argscmd flag to get the list of refs to draw at refresh time.Yann Dirson, Nov 2, 2007
  2. Paul MackerrasNov 17, 2007
  3. Yann DirsonNov 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.