git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[BUG] fast-import producing very deep tree deltas

From
Brian Downing <bdowning@lavos.net>
Date
Nov 12, 2007, 11:03 UTC
Message-ID
<20071112110354.GP6212@lavos.net>

I've happened upon a case where fast-import produces deep tree deltas. How deep? Really deep. 6035 entries deep to be precise for this case:

    depths: count 135970 total 120567366 min 0 max 6035 mean 886.72 median 3 std_dev 1653.48
    27b8a20bdf39fecd917e8401d3499013e49449d0 tree   32 99609547 6035 0000000000000000000000000000000000000000

This was with git-fast-import from 'next' as of a couple days ago, run with the default options (no --depth passed in).

Needless to say the pack that resulted was just about useless. Trying to repack it resulted in the "counting objects" phase running at about five objects per second.

I don't know much about the fast-import code, but I'd guess that the delta_depth member for the tree_content struct is either getting cleared inappropriately or is not being propagated correctly. I added a printout of the depth just before the store_object call in store_tree and it is never non-zero, even though the pack file clearly was generated with plenty of deltas.

I may have time to look at this more later this week, but I just wanted it to be known that this problem existed.

-bcd
Next: Brian Downing
Message 1 of 6 in “[BUG] fast-import producing very deep tree deltas”
  1. Brian DowningNov 12, 2007
  2. [BUG] fast-import quoting broken for renamesBrian Downing, Nov 12, 2007
  3. Linus TorvaldsNov 12, 2007
  4. Shawn O. PearceNov 13, 2007
  5. Shawn O. PearceNov 13, 2007
  6. Brian DowningNov 13, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.