git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: `git-send-email' doesn't specify `Content-Type'

From
Björn Steinbrink <b.steinbrink@gmx.de>
Date
Nov 10, 2007, 12:51 UTC
Message-ID
<20071110125126.GA7261@atjola.homenet>
In-Reply-To
<20071110123505.GA24445@bulgaria>
On 2007.11.10 04:35:05 -0800, Brian Swetland wrote:
Show 24 quoted lines
> [Björn Steinbrink <B.Steinbrink@gmx.de>]
> > On 2007.11.10 02:14:20 -0800, Brian Swetland wrote:
> > > 
> > > The example I have involves a coworker's name which needs non-ascii
> > > characters.  They are properly escaped in the From: line generated by
> > > git-format-patch.  git-send-email puts the generated From: line at the
> > > top of the body of the email, unescapes it (to utf-8), and proceeds to
> > > send the email with no Content-Type specified.
> > 
> > You mean that it converts the header field to utf-8? It doesn't do that
> > here (neither master nor 1.5.3.5) and IIRC that would be invalid anyway,
> > because Content-Type applies to exactly that, content, not headers. Your
> > sample has no non-ASCII characters (or at least I didn't see any), so
> > git-send-email doesn't add a header to specify a charset.
> 
> The first line of the patch is a From: field with Arve's name, in
> an (rfc822?) encoded format):
> From: =?utf-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= <arve@android.com>
> 
> The mail generated by git-send-email makes this From: line the first
> line of the *body* of the generated email.  This line in the body
> is no longer escaped, the utf8 characters are visible, but the header
> of the message does not have a Content-Type indicating a non-ascii
> encoding.

Ah! Commit author differs from mail sender, didn't think of that. That's probably the same problem as with the -s option, ie. that git-send-email only looks at the existing text and not add anything it adds itself when checking the encoding. Sorry for the noise.

Björn
Previous: Brian SwetlandNext: Jeff King
Message 6 of 13 in “`git-send-email' doesn't specify `Content-Type'”
  1. Ludovic CourtèsNov 10, 2007
  2. Johannes SchindelinNov 10, 2007
  3. Brian SwetlandNov 10, 2007
  4. Björn SteinbrinkNov 10, 2007
  5. Brian SwetlandNov 10, 2007
  6. Björn SteinbrinkNov 10, 2007
  7. Jeff KingNov 11, 2007
  8. Jeff KingNov 11, 2007
  9. Brian SwetlandNov 11, 2007
  10. Jeff KingNov 11, 2007
  11. Brian SwetlandNov 11, 2007
  12. Jeff KingNov 11, 2007
  13. Jeff KingNov 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.