Re: [PATCH] send-pack: segfault fix on forced push
- From
Jeff King <peff@peff.net>
- Date
- Nov 8, 2007, 09:43 UTC
- Message-ID
- <20071108094339.GA20766@sigill.intra.peff.net>
- In-Reply-To
- <7vsl3h2i2j.fsf@gitster.siamese.dyndns.org>
On Thu, Nov 08, 2007 at 01:38:12AM -0800, Junio C Hamano wrote:
Show 5 quoted lines
> When pushing to overwrite a ref that points at a commit we do > not even have, the recent "terse push" patch tried to get a > unique abbreviation for the non-existent (from our point of > view) object, which resulted in strcpy(buf, NULL) and > segfaulted.
Good catch. The fix looks obviously correct.
-Peff