Re: [PATCH] Use parseopts in builtin-fetch

From: Pierre Habouzit <madcoder@debian.org>
Date: Nov 5, 2007, 08:43 UTC
Message-ID: <20071105084333.GA25574@artemis.corp>
In-Reply-To: <Pine.LNX.4.64.0711042233590.7357@iabervon.org>

On Mon, Nov 05, 2007 at 03:35:34AM +0000, Daniel Barkalow wrote:

Show 6 quoted lines

> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> ---
> I mostly did this and the next one for practice with the API. I'm 
> impressed that "git fetch -vv" is even handled correctly without anything 
> special. Now that I've done it, assuming I did it right, it might as well 
> get added to the series.

  I believe the same patches (or very similar ones) are in pu but are
not in next yet because they conflict with the builtin-fetch recent
series.

  see http://git.madism.org/?p=git.git;a=blobdiff;f=builtin-fetch.c;h=12b1c4;hp=6b1750d;hb=7407915;hpb=61610e6

> +		OPT_BOOLEAN('q', "quiet", &quiet, "fetch silently"),

  there is an OPT__QUIET(&quiet) for this one.

> +	i = 1;
>  	if (i < argc) {
>  		int j = 0;
>  		refs = xcalloc(argc - i + 1, sizeof(const char *));

  this is wrong, you meant i = 0, and frankly, it's better to just strip
i altogether.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org