git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] receive-pack: don't mention successful updates

From
Jeff King <peff@peff.net>
Date
Nov 5, 2007, 05:11 UTC
Message-ID
<20071105051140.GB13144@sigill.intra.peff.net>
In-Reply-To
<20071105050517.GA6244@sigill.intra.peff.net>

The proposed updates are already shown to the user by send-pack, so there's no point. We continue to show errors, since they are unexpected.

Signed-off-by: Jeff King <peff@peff.net>
---
 receive-pack.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/receive-pack.c b/receive-pack.c
index 38e35c0..ed44b89 100644
--- a/receive-pack.c
+++ b/receive-pack.c
@@ -204,8 +204,6 @@ static const char *update(struct command *cmd)
 			error("failed to delete %s", name);
 			return "failed to delete";
 		}
-		fprintf(stderr, "%s: %s -> deleted\n", name,
-			sha1_to_hex(old_sha1));
 		return NULL; /* good */
 	}
 	else {
@@ -217,8 +215,6 @@ static const char *update(struct command *cmd)
 		if (write_ref_sha1(lock, new_sha1, "push")) {
 			return "failed to write"; /* error() already called */
 		}
-		fprintf(stderr, "%s: %s -> %s\n", name,
-			sha1_to_hex(old_sha1), sha1_to_hex(new_sha1));
 		return NULL; /* good */
 	}
 }
-- 
1.5.3.5.1530.g7353
Previous: Jeff KingNext: Jeff King
Message 3 of 6 in “more terse push output”
  1. 0/3 more terse push outputJeff King, Nov 5, 2007
  2. 1/3 more terse push outputJeff King, Nov 5, 2007
  3. 2/3 receive-pack: don't mention successful updatesJeff King, Nov 5, 2007
  4. 3/3 send-pack: require --verbose to show update of tracking refsJeff King, Nov 5, 2007
  5. Steffen ProhaskaNov 5, 2007
  6. Junio C HamanoNov 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.