Re: [PATCH] Fix an infinite loop in sq_quote_buf().
On Sun, Nov 04, 2007 at 08:26:22PM +0000, Johannes Sixt wrote:
Show 22 quoted lines
> sq_quote_buf() treats single-quotes and exclamation marks specially, but
> it incorrectly parsed the input for single-quotes and backslashes.
>
> Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
> ---
> quote.c | 2 +-
> t/t5510-fetch.sh | 7 +++++++
> 2 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/quote.c b/quote.c
> index 482be05..919d092 100644
> --- a/quote.c
> +++ b/quote.c
> @@ -26,7 +26,7 @@ void sq_quote_buf(struct strbuf *dst, const char *src)
>
> strbuf_addch(dst, '\'');
> while (*src) {
> - size_t len = strcspn(src, "'\\");
> + size_t len = strcspn(src, "'!");
> strbuf_add(dst, src, len);
> src += len;
> while (need_bs_quote(*src)) { Ouch, good catch :/ sorry about that.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org