Re: git-remote: Use of uninitialized value in string ne, line 248
- From
Pierre Habouzit <madcoder@debian.org>
- Date
- Oct 24, 2007, 20:39 UTC
- Message-ID
- <20071024203911.GC10900@artemis.corp>
- In-Reply-To
- <7vwstc68bk.fsf@gitster.siamese.dyndns.org>
On Wed, Oct 24, 2007 at 11:49:51AM +0000, Junio C Hamano wrote:
Show 24 quoted lines
> martin f krafft <madduck@madduck.net> writes:
>
> > piper:~> git remote show origin
> > * remote origin
> > URL: ssh://git.madduck.net/~/git/etc/mailplate.git
> > Use of uninitialized value in string ne at /usr/local/stow/git/bin/git-remote line 248.
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Perhaps....
>
> git-remote.perl | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/git-remote.perl b/git-remote.perl
> index 9ca3e7e..4cee044 100755
> --- a/git-remote.perl
> +++ b/git-remote.perl
> @@ -244,7 +244,8 @@ sub show_remote {
> print "* remote $name\n";
> print " URL: $info->{'URL'}\n";
> for my $branchname (sort keys %$branch) {
> - next if ($branch->{$branchname}{'REMOTE'} ne $name);
> + next if (!$branch->{$branchname}{'REMOTE'} ||
> + $branch->{$branchname}{'REMOTE'} ne $name);This looks better (wrt the "0" issue raised earlier):
+ next unless (defined($branch->{$branchname}{'REMOTE'}) && + $branch->{$branchname}{'REMOTE'} eq $name);
-- ·O· Pierre Habouzit ··O madcoder@debian.org OOO http://www.madism.org