Re: git-{diff,ls}-files from a subdirectory fails ...

From: Karl Hasselström <kha@treskal.com>
Date: Oct 24, 2007, 10:40 UTC
Message-ID: <20071024104055.GB3908@diana.vm.bytemark.co.uk>
In-Reply-To: <Pine.LNX.4.64.0710241104560.25221@racer.site>

On 2007-10-24 11:06:43 +0100, Johannes Schindelin wrote:

Show 18 quoted lines

> On Wed, 24 Oct 2007, Karl Hasselström wrote:
>
> > However, it doen't seem to work from a subdirectory:
> >
> >   kha@yoghurt:~/stgit-lib/stgit> git-diff-files --name-only
> >   stgit/utillib.py
> >
> >   kha@yoghurt:~/stgit-lib/stgit> GIT_DIR=/home/kha/stgit-lib/.git GIT_INDEX_FILE=/home/kha/stgit-lib/.git/index GIT_WORK_TREE=/home/kha/stgit-lib git-diff-files --name-only | wc
> >       170     170    3560
>
> From looking at it (very) briefly, it seems that you encountered the
> same bug that was fixed in
>
> dd5c8af176bb935a0b01a7dc2d5e022565c3aac3(Fix setup_git_directory_gently()
> with relative GIT_DIR & GIT_WORK_TREE).
>
> IOW if you run git version v1.5.3.4-14-gdd5c8af or newer, you should
> not experience this.

Thanks for the pointer; that looks like it might indeed fix this bug. Will hopefully have time to verify later today.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle