Re: [PATCH 4/7] Bisect: factorise "bisect_write_*" functions.

From: Christian Couder <chriscool@tuxfamily.org>
Date: Oct 24, 2007, 04:09 UTC
Message-ID: <200710240609.54597.chriscool@tuxfamily.org>
In-Reply-To: <7v640x7a4n.fsf@gitster.siamese.dyndns.org>

Le mercredi 24 octobre 2007, Junio C Hamano a écrit :

> Sort of offtopic, but is "factorise" a correct verb here?  I
> thought "factorise" is to express a non prime number as the
> product of prime numbers.

English is not my mother tongue so I very often make mistakes. Sorry about that.

Anyway my prefered online dictionary finds it:

http://www.wordreference.com/definition/factorise

> "refactor" is the act of splitting and merging pieces of
> functions for better reuse, isn't it?

Yes, it would be better.

I used "factorise" because as a french native speaker, I am always tempted to use word that sound the same as their french translation.

By the way I realised that the "bisect_write" function is still missing 'nolog="$3"', so I will send an updated patch.

Thanks, Christian.