Re: [PATCH] On error, do not list all commands, but point to --help option

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 21, 2007, 03:33 UTC
Message-ID: <20071021033318.GD14735@spearce.org>
In-Reply-To: <ir51if2y.fsf@blue.sea.net>

Jari Aalto <jari.aalto@cante.net> wrote:

> - Remove out call to list_common_cmds_help()

Even if the list is against this change (which I'm in favor of)...

> - Send error message to stderr, not stdout.

I really think this really should be done. CVS and SVN both print to stderr in this case, as does any other program I can think of that takes subcommands. Its just the right thing to do.

Show 7 quoted lines

> @@ -185,8 +185,7 @@ static void show_man_page(const char *git_cmd)
>  
>  void help_unknown_cmd(const char *cmd)
>  {
> -	printf("git: '%s' is not a git-command\n\n", cmd);
> -	list_common_cmds_help();
> +	fprintf(stderr, "git: '%s' is not a git-command. See --help\n\n", cmd);

Why are you still printing two LFs here? We have no additional text to display after this error message, we probably only need the one LF.

-- 
Shawn.