Re: [PATCH] Use exit 1 instead of die when req_Root fails.
- From
Frank Lichtenheld <frank@lichtenheld.de>
- Date
- Oct 17, 2007, 19:08 UTC
- Message-ID
- <20071017190822.GD9041@planck.djpig.de>
- In-Reply-To
- <118833cc0710170739i179e7389k1e44f70086ca88be@mail.gmail.com>
On Wed, Oct 17, 2007 at 10:39:52AM -0400, Morten Welinder wrote:
Show 8 quoted lines
> > made it into your repo. It fixes test failures on my machine that have > > been plauging me for months. > > That sounds more like a reason to fix the test. "die" is the perl > standard way of > reporting an error. It will print the error message on stderr, not on > stdout like > your version does.
Please note that git-cvsserver is special in that its output will never be displayed directly to the user but is always interpreted first by the client. So print "E something" is acutally in some cases more correct than print STDERR something.
Gruesse,
-- Frank Lichtenheld <frank@lichtenheld.de> www: http://www.djpig.de/