Re: [PATCH] Make the output of "git svn clone" less confusing.

From: Eric Wong <normalperson@yhbt.net>
Date: Oct 16, 2007, 09:32 UTC
Message-ID: <20071016093228.GA30503@soma>
In-Reply-To: <87k5poflp5.fsf@lysator.liu.se>

David Kågedal <davidk@lysator.liu.se> wrote:

Show 7 quoted lines

> The problem is that the first thing it prints is
> 
>   Initialized empty Git repository in .git/
> 
> even if actually created a subdirectory and changed into it first. But to the
> user, it looks like it is creating a .git/ dir in the directory he/she is
> started git from.

Thanks for bringing it up I just noticed this the other day myself and thought it might be confusing.

Show 18 quoted lines

> ---
>  git-svn.perl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> This change makes it more chatty, which might not be a good thing. But
> I think the previous output was worse.
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 777e436..d4450ca 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -286,6 +286,7 @@ sub do_git_init_db {
>  
>  sub init_subdir {
>  	my $repo_path = shift or return;
> +	print "Creating directory $repo_path\n";
>  	mkpath([$repo_path]) unless -d $repo_path;
>  	chdir $repo_path or die "Couldn't chdir to $repo_path: $!\n";

Since mkpath() isn't guaranteed to get called, maybe putting a

	print "Entering directory $repo_path\n"

right before the chdir is better.

The other option would be to alter git-init to print the absolute path of the repository being initialized...

-- 
Eric Wong