Re: git-fast-import crashes

From: Pierre Habouzit <madcoder@debian.org>
Date: Oct 13, 2007, 07:50 UTC
Message-ID: <20071013075027.GD7110@artemis.corp>
In-Reply-To: <20071013073640.GC7110@artemis.corp>

On sam, oct 13, 2007 at 07:36:40 +0000, Pierre Habouzit wrote:

Show 21 quoted lines

> On Sat, Oct 13, 2007 at 03:34:07AM +0000, Shawn O. Pearce wrote:
> > "Shawn O. Pearce" <spearce@spearce.org> wrote:
> > > Shun Kei Leung <kevinlsk@gmail.com> wrote:
> > > > I am using git 1.5.3.4.206.g58ba4-dirty on Mac OS X 10.4.
> > ....
> > > > Program received signal EXC_BAD_ACCESS, Could not access memory.
> > > > Reason: KERN_INVALID_ADDRESS at address: 0x64617469
> > ....
> > > This looks like it is
> > > memory corruption (e.g. someone overwriting a free'd segment),
> > > but that sort of memory corruption is very hard to track down.
> > 
> > OK, so the version you have (58ba4) is the latest fast-import after
> > the strbuf.c series went in.  The one immediately before that series
> > was 4bf538 and is probably actually stable.
> > 
> > So I wonder, can you test 4bf538 and then if it is good bisect
> > between those two commits?  There must be a memory corruption
> > introduced by one of the strbuf changes...
> 
>   Gasp, if you get the offending sha1 commit, don't forget to Cc: me.

  Okay, given that fast-import uses quote_c_style, I believe this is the
same but that the one that was reported already. I've read the full
`git diff 4bf53833dbca666f61b5177977e96d453527db20.. -- fast-import.c`
and nothing alarming shows up.

  Please try to apply:
http://git.madism.org/?p=git.git;a=commit;h=7406e83342cd445ac38c1753c5fce75377737e2f

  And see if that fixes the issue for you. Else a bisection would be
much appreciated. Thanks.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org