Re: [PATCH] git-cvsserver: added support for update -p
- From
Frank Lichtenheld <frank@lichtenheld.de>
- Date
- Oct 10, 2007, 20:00 UTC
- Message-ID
- <20071010200029.GK31659@planck.djpig.de>
- In-Reply-To
- <200710101316.03633.jan@swi-prolog.org>
On Wed, Oct 10, 2007 at 01:16:03PM +0200, Jan Wielemaker wrote:
Show 14 quoted lines
> + # if we have a -p we should just send the file
> + if ( exists ( $state->{opt}{p} ) )
> + {
> + if ( open my $fh, '-|', "git-cat-file", "blob", $meta->{filehash} )
> + { while ( <$fh> )
> + { print "M " . $_;
> + }
> + close $fh or die ("Couldn't close filehandle for transmitfile(): $!");
> + } else
> + { die("Couldn't execute git-cat-file");
> + }
> +
> + next;
> + }There seems to be inconsistent whitespace in the patch. And please never do that else\n{ again, it hurts my eye ;)
Will try to test (and write a testcase for) it tomorrow.
Gruesse,
-- Frank Lichtenheld <frank@lichtenheld.de> www: http://www.djpig.de/