Re: [PATCH 1/2] rev-list: implement --bisect-all

From: Christian Couder <chriscool@tuxfamily.org>
Date: Oct 8, 2007, 05:08 UTC
Message-ID: <200710080708.46579.chriscool@tuxfamily.org>
In-Reply-To: <Pine.LNX.4.64.0710080442420.4174@racer.site>

Hi Dscho,

Le lundi 8 octobre 2007, Johannes Schindelin a écrit :

Show 9 quoted lines

> Hi,
>
> On Mon, 8 Oct 2007, Christian Couder wrote:
> > This option makes it possible to see all the potential bisection
> > points. The best ones are displayed first.
>
> Would it not be better to pass --bisect-vars a list of commits that we do
> not want to see?  It could then mark them as "DUNNO", and still just
> output a single commit.

The problem is that after --bisect-vars we already pass some "good" and then a bad commit. So we have to use another flag like --bisect-dunno and put the dunno commits after this one.

Then there is the problem that revision.c reorders arguments and doesn't know about "--bisect-*" flags. It is also used by a lot of other commands.

After struggling with revision.c for some time, I thought it would be simpler and safer to come up first with something in shell.

Also please note that in some cases we cannot just output a single commit, because we just dunno which commit is the first bad one.

> IMHO such a logic does not belong into a shell script, but into the C
> core.

There is a lot of the bisect logic implemented in git-bisect.sh already. The long term plan is to rewrite it in C, but I am not sure that the "dunno" logic should be the first part of it to be done in C.

Also I thought it was still fine to prototype new features in shell.

Best regards, Christian.