git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGit PATCH 3/8] Fix up the help text for "stg edit"

From
Karl Hasselström <kha@treskal.com>
Date
Oct 7, 2007, 23:17 UTC
Message-ID
<20071007231729.12626.64039.stgit@yoghurt>
In-Reply-To
<20071007231446.12626.14259.stgit@yoghurt>

The sentence structure was strange, and the example format was somewhat misleading (StGit doesn't care about sign-off lines, for example).

Signed-off-by: Karl Hasselström <kha@treskal.com>
---
 stgit/commands/edit.py |   24 +++++++++++++++---------
 1 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/stgit/commands/edit.py b/stgit/commands/edit.py
index 63c710b..e968e25 100644
--- a/stgit/commands/edit.py
+++ b/stgit/commands/edit.py
@@ -30,19 +30,25 @@ from stgit import stack, git
 help = 'edit a patch description or diff'
 usage = """%prog [options] [<patch>]
 
-Edit the given patch (defaulting to the current one) description,
-author information or its diff (if the '--diff' option is
-passed). Without any other option, the command invokes the editor with
-the patch description and diff in the form below:
+Edit the description and author information of the given patch (or the
+current patch if no patch name was given). With --diff, also edit the
+diff.
 
-  Subject line
+The editor is invoked with the following contents:
 
-  From: author information
+  Patch short description
+
+  From: A U Thor <author@example.com>
   Date: creation date
 
-  Patch description
+  Patch long description
+
+If --diff was specified, the diff appears at the bottom, after a
+separator:
+
+  ---
 
-  Signed-off-by: author
+  Diff text
 
 Command-line options can be used to modify specific information
 without invoking the editor.
@@ -54,7 +60,7 @@ these files using the '--file' and '--diff' options.
 """
 
 options = [make_option('-d', '--diff',
-                       help = 'allow the editing of the patch diff',
+                       help = 'edit the patch diff',
                        action = 'store_true'),
            make_option('-f', '--file',
                        help = 'use FILE instead of invoking the editor'),
Previous: Karl HasselströmNext: Karl Hasselström
Message 4 of 11 in “Miscellaneous fixes and improvements”
  1. 0/8 Miscellaneous fixes and improvementsKarl Hasselström, Oct 7, 2007
  2. 1/8 Add --ack/--sign options to "stg new"Karl Hasselström, Oct 7, 2007
  3. 2/8 New test: "stg pop --keep"Karl Hasselström, Oct 7, 2007
  4. 3/8 Fix up the help text for "stg edit"Karl Hasselström, Oct 7, 2007
  5. 4/8 Don't split long and short description in "stg edit"Karl Hasselström, Oct 7, 2007
  6. David BrownOct 7, 2007
  7. Karl HasselströmOct 8, 2007
  8. 5/8 Make a common superclass for all StGit exceptionsKarl Hasselström, Oct 7, 2007
  9. 6/8 Simplify debug level error checkingKarl Hasselström, Oct 7, 2007
  10. 7/8 Discard stderr output from git-rev-parseKarl Hasselström, Oct 7, 2007
  11. 8/8 Remove the --force flag to "stg rebase" and "stg pull"Karl Hasselström, Oct 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.