Re: [PATCH 2/2] Run garbage collection with loose object pruning after svn dcommit
- From
- Peter Baumann <waste.manager@gmx.de>
- Date
- Oct 5, 2007, 08:21 UTC
- Message-ID
- <20071005082110.GA4797@xp.machine.xx>
- In-Reply-To
- <20071005001528.GA13029@midwinter.com>
On Thu, Oct 04, 2007 at 05:15:28PM -0700, Steven Grimm wrote:
Show 15 quoted lines
> git-svn dcommit, by virtue of rewriting history to insert svn revision IDs, > leaves old commits dangling. Since dcommit is already unsafe to run > concurrently with other git commands, no additional risk is introduced > by making it prune those old objects as needed. > > Signed-off-by: Steven Grimm <koreth@midwinter.com> > --- > > This is in response to a colleague who complained that, after I > installed the latest git release, he was getting lots of "too many > unreachable loose objects" errors from the new "git gc --auto" run. > Those objects turned out to be dangling commits from a year's worth of > git-svn usage, since every git-svn commit will abandon at least one > existing commit in order to rewrite it with the svn version data. >
I don't like the automatic prune. What if someone has other objects in there which shouldn't be pruned? Making git svn dcommit doing the prune would be at least suprising, because how is one supposed to know that doing a commit into svn will prune all your precious objects?
Sure, I can unterstand from where you are coming from, but I'd prefere if this could be specified on a case by case basis, e.g. from the cmdline or as a config option.
-Peter
Show 28 quoted lines
> git-svn.perl | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 777e436..be62ee1 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -441,6 +441,12 @@ sub cmd_dcommit {
> }
> command_noisy(@finish, $gs->refname);
> $last_rev = $cmt_rev;
> +
> + # rebase will have made the just-committed revisions
> + # unreachable; over time that can build up lots of
> + # loose objects in the repo. prune is unsafe to run
> + # concurrently but so is dcommit.
> + command_noisy(qw/gc --auto --prune/);
> }
> }
> }
> --
> 1.5.3.4.203.gcc61a
>
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>