git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add a --dateformat= option to git-for-each-ref

From
Jeff King <peff@peff.net>
Date
Sep 28, 2007, 18:47 UTC
Message-ID
<20070928184710.GA5560@coredump.intra.peff.net>
In-Reply-To
<200709281516.05438.andyparkins@gmail.com>
On Fri, Sep 28, 2007 at 03:15:58PM +0100, Andy Parkins wrote:
Show 6 quoted lines
> > like a sane way to implement these sorts of things (e.g.,
> > "%(objectsize:human)", "%(parent:1)", etc).
> 
> I'd thought about doing it like that, but imagined that there would
> objections that it was overcomplicating git-for-each-ref.  As you
> think that's acceptable, I'll do it.

Well, I'm not sure my opinion counts for much, but at least there are now two of us. :)

> A patch series that implements both your requested changes to follow.
Patches 1/2 look fine to me (but I agree with the squash suggestion).

3/4 are not exactly what I had in mind, but I think are reasonable in this case. Rather than treating it was ":format", I had imagined more of a ":attribute1:attribute2" style, where some attributes may be understood by all substitutions (e.g., the moral equivalent of shell's ":-" and ":+"), and some only by some substitutions (such as date formats). And on top of that, these sorts of substitutions should be unified with the --pretty=format machinery.

Of course, that is a much larger task and you probably just want to do your date formatting and get your other work done. So I think your implementation is reasonable, in that it accomplishes what you want in a reasonable amount of code, and its syntax doesn't prevent moving towards what I described above (since %(foo:bar:baz) is currently nonsensical, we would be free to adapt its meaning later).

So in a very verbose way,
Acked-by: Jeff King <peff@peff.net>
-Peff
Previous: Junio C Hamano
Message 15 of 15 in “Add a --dateformat= option to git-for-each-ref”
  1. Add a --dateformat= option to git-for-each-refAndy Parkins, Sep 26, 2007
  2. Jeff KingSep 26, 2007
  3. Andy ParkinsSep 28, 2007
  4. 1/4 Add parse_date_format() convenience function for converting a format string to an enum date_modeAndy Parkins, Sep 28, 2007
  5. 2/4 Use parse_date_format() in revisions.c to parse the --date parameterAndy Parkins, Sep 28, 2007
  6. Johannes SchindelinSep 28, 2007
  7. Andy ParkinsSep 28, 2007
  8. Junio C HamanoSep 28, 2007
  9. 1/3 Use parse_date_format() convenience function for converting a format string to an enum date_mode in revisions.cAndy Parkins, Sep 29, 2007
  10. 2/3 Make for-each-ref allow atom names like "<name>:<something>"Andy Parkins, Sep 29, 2007
  11. 3/3 Make for-each-ref's grab_date() support per-atom formattingAndy Parkins, Sep 29, 2007
  12. 3/4 Make for-each-ref allow atom names like "<name>:<something>"Andy Parkins, Sep 28, 2007
  13. 4/4 Make for-each-ref's grab_date() support per-atom formattingAndy Parkins, Sep 28, 2007
  14. Junio C HamanoSep 29, 2007
  15. Jeff KingSep 28, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.