Re: Use of strbuf.buf when strbuf.len == 0

From: Pierre Habouzit <madcoder@debian.org>
Date: Sep 27, 2007, 11:37 UTC
Message-ID: <20070927113718.GF10289@artemis.corp>
In-Reply-To: <20070927112204.GE10289@artemis.corp>

On Thu, Sep 27, 2007 at 11:22:04AM +0000, Pierre Habouzit wrote:

> (it's arguable > that it's a right thing to assume though)

  I find this ugly, so I've even checked if we did assume that, which is
easy now that such places all use strbuf_detach. One place seemed to,
but wasn't, so I patched it so that it's not the case anymore.

  All other places that use strbuf_detach don't use the fact that it can
return NULL to detect error cases, so we are safe.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org