git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] Cleanup style nit of 'x == NULL' in remote.c

From
Shawn O. Pearce <spearce@spearce.org>
Date
Sep 25, 2007, 04:13 UTC
Message-ID
<20070925041314.GA11363@spearce.org>

Git style tends to prefer "!x" over "x == NULL". Make it so in these handful of locations that were not following along.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 remote.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/remote.c b/remote.c
index e3c3df5..ac354f3 100644
--- a/remote.c
+++ b/remote.c
@@ -416,7 +416,7 @@ int remote_find_tracking(struct remote *remote, struct refspec *refspec)
 	int i;
 
 	if (find_src) {
-		if (refspec->dst == NULL)
+		if (!refspec->dst)
 			return error("find_tracking: need either src or dst");
 		needle = refspec->dst;
 		result = &refspec->src;
@@ -613,7 +613,7 @@ static int match_explicit(struct ref *src, struct ref *dst,
 	if (!matched_src)
 		errs = 1;
 
-	if (dst_value == NULL)
+	if (!dst_value)
 		dst_value = matched_src->name;
 
 	switch (count_refspec_match(dst_value, dst, &matched_dst)) {
@@ -633,7 +633,7 @@ static int match_explicit(struct ref *src, struct ref *dst,
 		      dst_value);
 		break;
 	}
-	if (errs || matched_dst == NULL)
+	if (errs || !matched_dst)
 		return 1;
 	if (matched_dst->peer_ref) {
 		errs = 1;
-- 
1.5.3.2.124.g2456-dirty
Message 1 of 1 in “Cleanup style nit of 'x == NULL' in remote.c”
  1. 1/3 Cleanup style nit of 'x == NULL' in remote.cShawn O. Pearce, Sep 25, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.