Re: git-send-email is omitting author and date lines

From: martin f krafft <madduck@madduck.net>
Date: Sep 24, 2007, 11:08 UTC
Message-ID: <20070924110817.GA15797@lapse.madduck.net>
In-Reply-To: <7v4phlc668.fsf@gitster.siamese.dyndns.org>

also sprach Junio C Hamano <gitster@pobox.com> [2007.09.24.0029 +0100]:

> Was the commit authored by yourself?

Sorry for barking in here, but Hanspeter tried to submit a patch to me and that's when this issue arose.

Yes, he is the author of the commit, as in: user.name and user.email are the same for the commit and for the email, and this seems to be the reason the commit header is left out of the email, causing git-am to use the RFC822 From header instead:

  - patch by Jane, email sent From Jane: no separate From header
  - patch by Jane, email sent From Joe: separate From Jane header

But information *does* get lost, namely the date. If I send a patch by email and it gets merged by the recipient, the date of the commit will be the date of the email, not the date of original commit, or when it was merged.

To be honest, I have no real preference on this, but it just seems strange that out of three dates:

  - original commit
  - email sent
  - commit merged

git-send-email/git-am cause the second to be used, which is the one that makes the *least* sense IMHO.

-- 
martin;              (greetings from the heart of the sun.)
  \____ echo mailto: !#^."<*>"|tr "<*> mailto:" net@madduck
 
"i dislike arguments of any kind. they are always vulgar, and often
 convincing."
                                                        -- oscar wilde
 
spamtraps: madduck.bogus@madduck.net