[DON'T MERGE PATCH 7/7]
On Fri, Sep 21, 2007 at 07:03:29AM +0000, Pierre Habouzit wrote:
Show 18 quoted lines
> On jeu, sep 20, 2007 at 10:05:06 +0000, Pierre Habouzit wrote:
> > On mer, sep 19, 2007 at 10:42:16 +0000, Pierre Habouzit wrote:
> >
> > As someone pointed to me off-list the above should be:
> > + if (rf_one) {
> > + (*write_ref)[targets] = xmemdupz(rf_one + 1, buf.len - (rf_one + 1 - buf.buf));
> > + } else {
> >
> > Or better:
> > + if (rf_one) {
> > + rf_one++; /* skip \t */
> > + (*write_ref)[targets] = xmemdupz(rf_one, buf.buf + buf.len - rf_one);
> > + } else {
> >
> > Which is definitely more readable.
>
> damn it was not the error that was reported to me, there is another
> one, I'll roll a new patch, sorry :/ Okay this patch is worthless, the previous version worked the same, I
totally missed what it did. I should not code when I'm too tired, I'm
sorry.
Don't merge patch 7/7 it's broken.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
Pierre Habouzit <madcoder@debian.org>